jenkinsci / jenkinsci/credentials-binding-plugin
[JENKINS-64066] credentialsbinding.Binding abstract class allows variable name to be null
- Dominant language
- Java
- Stars
- 57
- Forks
- 108
- PR merge metrics
- No merged PRs in 30d
Description
The org.jenkinsci.plugins.credentialsbinding.Binding abstract class never validates that the variable parameter/field is non-null. This causes a bug in all of its subclasses (FileBinding, StringBinding, UsernamePasswordBinding, etc.) where if the user doesn't include a variable in the constructor, it tries to use null.
Masking supported pattern matches of $null
Instead, it should throw a proper exception in the constructor if variable is null or empty.
---
Originally reported by rittneje, imported from: credentialsbinding.Binding abstract class allows variable name to be null
Raw content of original issue
The org.jenkinsci.plugins.credentialsbinding.Binding abstract class never validates that the variable parameter/field is non-null. This causes a bug in all of its subclasses (FileBinding, StringBinding, UsernamePasswordBinding, etc.) where if the user doesn't include a variable in the constructor, it tries to use null.
Masking supported pattern matches of $null
Instead, it should throw a proper exception in the constructor if variable is null or empty.
Contributor guide
Assessment
This issue has not been assessed yet.