jenkinsci / jenkinsci/conditional-buildstep-plugin
[JENKINS-25763] implement syntax verification for parameters
- Dominant language
- Java
- Stars
- 17
- Forks
- 39
- Avg merge
- 23h 17m
- Merged PRs (30d)
- 1
Description
While running the plugin and having the typo/wrong syntax in "token" field (missing " in my case), allows to execute further steps even when in advanced options of this plugin "fail the build" is set on evaluation failure (see config.png for setup example). Execution.png has the steps that are placed after the plugin that is having bad behaviour and they are executed.
In my opinion there should be a syntax verification performed there, and when syntax is not correct, should fail the job at this step or at least this situation should be treated as condition evaluation failure.
If i can assist with more information please let me know to improve this wonderfull tool.
Thank you.
---
Originally reported by wojtek_haj, imported from: implement syntax verification for parameters
Raw content of original issue
While running the plugin and having the typo/wrong syntax in "token" field (missing " in my case), allows to execute further steps even when in advanced options of this plugin "fail the build" is set on evaluation failure (see config.png for setup example). Execution.png has the steps that are placed after the plugin that is having bad behaviour and they are executed.
In my opinion there should be a syntax verification performed there, and when syntax is not correct, should fail the job at this step or at least this situation should be treated as condition evaluation failure.
If i can assist with more information please let me know to improve this wonderfull tool.
Thank you.
- environment:
RH 6.5
2 attachments
- [config.PNG](https://issues.jenkins.io/secure/attachment/28066/config.PNG)
> 
- [execution.PNG](https://issues.jenkins.io/secure/attachment/28067/execution.PNG)
> 
Contributor guide
Research direction
Start by tracing evaluation from the plugin's token field and the advanced “fail the build” option. Reproduce the malformed-token case described in the issue, then verify that invalid syntax is treated as an evaluation failure and prevents subsequent steps from running.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100