jenkinsci / jenkinsci/branch-api-plugin
[JENKINS-60122] jenkins.branch.WorkpsaceLocatorImpl.MODE=DISABLED does not disable the extension
- Dominant language
- Java
- Stars
- 39
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I tried to disable the WorkspaceLocatorImpl by setting the property jenkins.branch.WorkspaceLocatorImpl.MODE to DISABLED
to get a workaround for the issue JENKINS-54776">JENKINS-54776
I assumed that the property disabled the class completely but the WorkspaceCollectorImpl.Collector class still gets called and tries to get a lock on the node which causes the issue JENKINS-54776">JENKINS-54776.
That was not my expected behaviour, I guess that either the property does not work correctly or the javadoc of the property needs some clarification.
---
Originally reported by
nirud, imported from: jenkins.branch.WorkpsaceLocatorImpl.MODE=DISABLED does not disable the extension
Raw content of original issue
Hello,
I tried to disable the WorkspaceLocatorImpl by setting the property jenkins.branch.WorkspaceLocatorImpl.MODE to DISABLED
to get a workaround for the issueJENKINS-54776I assumed that the property disabled the class completely but the WorkspaceCollectorImpl.Collector class still gets called and tries to get a lock on the node which causes the issue
JENKINS-54776.That was not my expected behaviour, I guess that either the property does not work correctly or the javadoc of the property needs some clarification.
environment
```
jenkins version 2.190.2
branch-api 2.5.4
```
Contributor guide
Research direction
Start by reading the jenkins.branch.WorkspaceLocatorImpl.MODE property and the WorkspaceCollectorImpl.Collector entry point mentioned in the report. Reproduce the DISABLED behavior using the reported Jenkins and branch-api versions, then determine whether the property behavior or its Javadoc needs correction; done means the observed behavior matches the documented expectation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100