jenkinsci / jenkinsci/benchmark-plugin

setResultSelected Blocked on Firefox

Open
#37 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7
Forks
4
PR merge metrics
No merged PRs in 30d

Description

When navigating to the "Result Page" for a particular result to view the build-over-build graph of the data using Firefox, the ajax call to `setResultSelected` is blocked, resulting in either:
A) The wrong data being displayed (the previously displayed data)
B) A redirect back to the summary page (if no results are currently loaded by the plugin)

I believe that this is caused by Firefox blocking the yet-to-begin asynchronous ajax operation because the page which initiated it is being left (the next line causes a redirect).

If my theory is correct, I believe the best solution is to wait for the `setResultSelected` operation to complete before redirecting to the results page. Maybe the operation can be made synchronous, or maybe the redirect can happen in a callback. My javascript-foo isn't strong enough to suggest a fix, unfortunately.

This might also be an opportunity to prevent the redirect and display an error message if something goes wrong, rather than redirecting to data that might not be right.

Contributor guide

Open the contributing guide

Research direction

Start by locating the JavaScript entry point that calls setResultSelected when navigating to the Result Page, then reproduce the navigation in Firefox and inspect the asynchronous request behavior. Done means the selected result is reliably loaded before navigation, with an error path that does not display stale data or redirect incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.