jenkinsci / jenkinsci/active-directory-plugin
[JENKINS-76220] add source ip or host name to log on authentication failure.
- Dominant language
- Java
- Stars
- 53
- Forks
- 115
- PR merge metrics
- No merged PRs in 30d
Description
we encountered a situation in our jenkins environment where an agent is trying to connect to the controller using the swarm plugin.
in order to do so, the node is using username with password or a specific token, but they are wrong.
our problem - we cannot disable the user since other nodes are also using it to connect.
we see hundreds of failures to authenticate inthe jenkins controller log, but we don't know what is their source.
we rather not use a sniffer (like wireshark) to try and find the source for this problem (the source node which made the request), so we ask if it is possible to add the source ip or source host name to the log right next to the bad credentials exception.
the attachment contains the log messge on the controller where we want the extra information about the failed login.
---
Originally reported by
amidar, imported from: add source ip or host name to log on authentication failure.
fbelzunc
Raw content of original issue
we encountered a situation in our jenkins environment where an agent is trying to connect to the controller using the swarm plugin.
in order to do so, the node is using username with password or a specific token, but they are wrong.
our problem - we cannot disable the user since other nodes are also using it to connect.
we see hundreds of failures to authenticate inthe jenkins controller log, but we don't know what is their source.
we rather not use a sniffer (like wireshark) to try and find the source for this problem (the source node which made the request), so we ask if it is possible to add the source ip or source host name to the log right next to the bad credentials exception.
the attachment contains the log messge on the controller where we want the extra information about the failed login.
environment
```
any jenkins version.
any os version.
any active directory plugin version.
```
1 attachment
- [jenkins-active-directory-problem.txt](https://issues.jenkins.io/secure/attachment/65000/jenkins-active-directory-problem.txt)
Contributor guide
Research direction
Start with the attached jenkins-active-directory-problem.txt log and trace the active-directory-plugin authentication-failure path that emits the bad-credentials exception. Done means the controller log includes the source IP or host name alongside that failure, with coverage for the reported authentication scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100