Use multiply-with-overflow intrinsics instead of compute_size_with_overflow
Open
@davidtgoldblatt is already working on this.
Since Jan 20, 2017.
refactor
- Dominant language
- C
- Stars
- 11.2k
- Forks
- 1.6k
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 13
Description
compute_size_with_overflow does some complicated logic to determine if the product of two numbers (the arguments to calloc) will overflow.
Instead, we should use __builtin_mul_overflow or larger integer types, where available.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.