jemalloc / jemalloc/jemalloc

Valgrind integration

Open
#2,374 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
11.2k
Forks
1.6k
Avg merge
4d 8h
Merged PRs (30d)
13

Description

I maintain Valgrind on FreeBSD and I've been wondering a bit about the Valgrind integration that was in jemalloc.

I saw on some old manpages that there were some options for Valgrind:

https://www.unix.com/man-page/FreeBSD/3/malloc/

I was wondering what these did and what was the benefit.

Initially I sent an e-mail to David Goldblatt who said

"We got rid of most of the internal handling of valgrind integration a while back. IIRC this wasn't borne of any specific opposition, but we didn't have any CI set up for it and so we kept breaking it accidentally (and decided it was better to not pretend that it worked). I think the man page references should be removed in current versions.

Jemalloc isn't my day job any more so I don't want to commit the current maintainers to anything, but I think that they'd probably be receptive to reinserting the valgrind hooks so long as it was careful about the fast path and came with CI testing too. Probably the best followup is on a github issue (feel free to quote me on any of this if you'd like)."

So I'm posting here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current state of jemalloc's Valgrind integration and the existing CI testing setup, with attention to the fast path. The scope is not settled: determine whether the work should restore hooks, add CI coverage, and update the outdated manpage references, then define completion criteria with the maintainers.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
testing, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.