jeffbski / jeffbski/wait-on

Did you remove support for `--window`?

Open
#81 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
JavaScript
Stars
2k
Forks
87
PR merge metrics
No merged PRs in 30d

Description

According to the docs it seems like the window argument should still work. But by looking at the code it seems like it's only implemented by `createFileResource`, not by `createHTTP$` and the other protocols.

Was window support left out on purpose, or was it a mistake during the 5.0.0 release?

For example, this command immediately returns with a 200.
```
$ wait-on -v --window 30000 https://www.google.com
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the documentation for --window, then inspect createFileResource, createHTTP$, and the implementations for the other protocols to compare how the argument is handled. Run the reported wait-on command and verify that window behavior is either consistently supported across protocols or clearly documented as limited to file resources.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.