v8.0.5 contains a breaking change
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 87
- PR merge metrics
- No merged PRs in 30d
Description
👋🏼 Hello!
https://github.com/jeffbski/wait-on/releases/tag/v8.0.5 bumped to joi@18 which dropped support for node 18
wait-on made this change in a patch, but since [its `package.json#engines#node` supported node 18](https://github.com/jeffbski/wait-on/blob/f6fbfd5c86c78f819a77e15dd746a1b15c56b3b4/package.json#L25-L26), this was a breaking change.
It's been two months at this point and you've already updated the engines in a subsequent major, so... probably not much to do here. I just wanted to call this out and suggest documenting this in the v8.0.5 release notes.
I'd also recommend running your package's CI against your earliest and latest supported versions with [`npm ci --engine-strict`](https://docs.npmjs.com/cli/v11/using-npm/config#engine-strict) to catch this on bump PRs directly.
Contributor guide
No contributing guide indexed for this repository
Research direction
Review the v8.0.5 release page and the package.json engines declaration referenced in the issue. Document that the joi@18 update dropped Node 18 support, and verify the release notes accurately describe the breaking change; the suggested npm ci --engine-strict CI check is additional follow-up rather than the core task.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- documentation, release
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100