jd-opensource / jd-opensource/taro-ui
麻烦统一度量衡
Open
enhancement
UI
- Dominant language
- TypeScript
- Stars
- 4.7k
- Forks
- 740
- PR merge metrics
- No merged PRs in 30d
Description
发现Taro-ui中size相关，有三种写法
1.直接Taro.pxTransform(size)
2.Taro.pxTransform(size * 2)
3.size+'px'
是出于什么考虑这么设计，麻烦统一下，有点反人类
https://github.com/NervJS/taro-ui/blob/1352bebb2347fa4ed1467375a7025d9130b8860b/src/components/progress/index.js#L33
https://github.com/NervJS/taro-ui/blob/1352bebb2347fa4ed1467375a7025d9130b8860b/src/components/icon/index.js#L60
https://github.com/NervJS/taro-ui/blob/1352bebb2347fa4ed1467375a7025d9130b8860b/src/components/loading/index.js#L17
https://github.com/NervJS/taro-ui/issues/112#issuecomment-514445808
Contributor guide
Assessment
This issue has not been assessed yet.