jcubic / jcubic/lips

Use trampoline on all recursive functions inside JavaScript

Open
#74 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
507
Forks
45
Avg merge
11h 22m
Merged PRs (30d)
4

Description

This code throw error with stack overflow

(range 10000)

There are two reasons first Pair.fromArray is recursive second cycle detection is also recursive.

To solve the problem all recursive function in JavaScript should use trampoline so it don't overflow the stack.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the stack overflow with (range 10000), then inspect the recursive paths identified in Pair.fromArray and cycle detection. Done means the recursive functions involved use trampolining and the example no longer overflows the JavaScript stack.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.