jcubic / jcubic/lips

Check all functions that use typecheck "number"

Open
#282 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
507
Forks
45
Avg merge
11h 22m
Merged PRs (30d)
4

Description

Some functions accept integers. Like Array/vector indexes. Check all functions and replace:

(typecheck "fn" variable "number")

with

(typecheck-number "fn" variable '("integer" "bigint"))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the codebase for uses of typecheck with "number", then inspect each function to determine whether it accepts integer values such as array or vector indexes. Replace the applicable checks with the requested typecheck-number form and run the existing test suite to verify that integer and bigint inputs remain supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.