`tc check` runs top-level prettier on subpackages' code
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 20m
- Merged PRs (30d)
- 1
Description
Causes it to fail to respect subpackage .gitignores:
~/gh/timestream (cli) $ tc check
@jcoreio/toolchain@4.12.4
$ prettier --ignore-path .gitignore -c . '!pnpm-lock.yaml'
Checking formatting...
[warn] packages/http/coverage/lcov-report/base.css
[warn] packages/http/coverage/lcov-report/block-navigation.js
[warn] packages/http/coverage/lcov-report/decodeTimestream.ts.html
[warn] packages/http/coverage/lcov-report/FetchDataSource.ts.html
[warn] packages/http/coverage/lcov-report/fetchTimestreamData.ts.html
[warn] packages/http/coverage/lcov-report/HttpPostWritableStream.ts.html
[warn] packages/http/coverage/lcov-report/index.html
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the entry point for tc check and trace the configuration that runs the shown top-level Prettier command with --ignore-path .gitignore. Verify how subpackage .gitignore files are handled, then confirm that generated files such as packages/http/coverage/lcov-report are no longer checked while intended source files still are.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100