jchambers / jchambers/pushy

Breaking change in 0.15.1 regarding ApnsClient, ApnsClientBuilder

Open
#951 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.9k
Forks
460
PR merge metrics
No merged PRs in 30d

Description

Hi,

We tried upgrading from 0.15.0 to 0.15.1 and we are observing a breaking change in the API of the ApnsClientBuilder / ApnsClient.

We extended these classes to be able to configure our own SSLContext, which is allowing us to use a dynamic trust manager or the cipher suites of our own choice.

In 0.15.1, the way to pass an SSLContext to the ApnsClient is via the new ApnsClientConfiguration which is package-private.

Would it be possible to make _ApnsClientConfiguration_ **public** instead so that our code can keep working?

Thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.