jcfischer / jcfischer/supertag-cli
CI smoke-test: fail on any signal-kill, not just SIGKILL (137)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 49
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Non-blocking follow-up from PR #88 review.
The macOS binary smoke-test currently fails only on exit 137 (SIGKILL — the unsigned-binary symptom #88 targeted). Other signal-kills (SIGSEGV=139, SIGABRT=134) currently pass as "ok". A future enhancement could treat any rc >= 128 (signal-terminated) at startup as a failure, catching a broader class of broken-binary regressions.
Scope note: deliberately out of scope for #88, which targeted the codesign/SIGKILL issue specifically. Low priority.
Source: sage review of #88.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the macOS binary smoke-test and its current exit-137 handling, then run the existing CI smoke test to confirm its behavior. Update the check so startup terminations with return codes at or above 128 fail, and verify that signal-related failures no longer pass as successful.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100