jcabi / jcabi/jcabi-github

RtIssueITCase integration test does not pass when User does not have name

Open
#1,178 2 comments 0 reactions 0 assignees View on GitHub
bug DEV
Dominant language
Java
Stars
307
Forks
144
Avg merge
1d 22h
Merged PRs (30d)
14

Description

There is an invalid assumption in [User.java:179](https://github.com/jcabi/jcabi-github/blob/master/src/main/java/com/jcabi/github/User.java#L179) - `@NotNull(message = "Name is never NULL")`. Github user name can be empty - see example [here](https://api.github.com/users/kowal666). When user name is null the `RtIssueITCase` fails.

Tested with below command with `` and `` replaced as [described here](https://github.com/jcabi/jcabi-github#how-to-contribute).

```
mvn clean install -Dit.test=RtIssueITCase -Dfailsafe.github.key= -Dfailsafe.github.key.second= -Dfailsafe.github.repo=kowal666/brand24
```

I ignored `RtIssueITCase.talksInGithubProject()` test to avoid error and merge PR #952.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.