jbcoe / jbcoe/value_types

Possible issues with deduction guides from p1518r2

Open
#501 18 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C++
Stars
87
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Does https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1518r2.html somehow also apply to indirect?

I.e. should it be:

```diff
- constexpr indirect(allocator_arg_t, const Allocator& a, const indirect& other);
+ constexpr indirect(allocator_arg_t, const type_identity_t& a, const indirect& other);

- constexpr indirect(allocator_arg_t, const Allocator& a, indirect&& other);
+ constexpr indirect(allocator_arg_t, const type_identity_t& a, indirect&& other);
```

I am not sure, but I got reminded of P1518 and at least wanted to mention it.

Possibly related: https://github.com/microsoft/STL/issues/4060

We're currently consistent with tuple: https://eel.is/c++draft/tuple.tuple which might be the right way to be.

Taken from conversation with @Ukilele on another issue #497

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.