jbcoe / jbcoe/mylang

Remove unwanted `unwrap`s

Open
#113 0 comments 0 reactions 1 assignee Claimed by @jbcoe View on GitHub
Dominant language
Rust
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Perhaps neither of the below needs to be `unwrap`.

```
src\token.rs
68: String::from_utf8(self.text.to_vec()).unwrap()

src\driver.rs
139: token.offset() - text[0..token.offset()].rfind('\n').unwrap()
```

See if you can turn them into real `Error`s, using `thiserror`. Add test cases.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.