jbaruch / jbaruch/coding-policy

release SKILL.md invokes every script bare, but packaging ships them 0644

Open
#465 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
2
Avg merge
9h 22m
Merged PRs (30d)
81

Description

Split out of #463, where Copilot raised it against the one step that PR adds.

skills/release/SKILL.md invokes each of its scripts as a bare path:

skills/release/poll-pr-reviews.sh <owner> <repo> <pr-number>
skills/release/watch-pr-reviews.sh <owner> <repo> <pr-number>
skills/release/request-copilot-review.sh <owner> <repo> <pr-number>
skills/release/dismiss-stale-reviews.sh <owner> <repo> <pr-number>

That works from a clone of this repo, where git preserves the 0755 mode. It does not work from an installed plugin: tessl packaging normalizes plugin files to 0644, so a bare invocation is permission denied before the script runs. Other skills in this plugin carry the bash prefix for exactly that reason.

The fix is the whole file at once, not one step. rules/skill-authoring.md Script References forbids mixing the two conventions inside one SKILL.md, so converting a single invocation is worse than leaving it — which is why #463 left its own step matching its neighbours and filed this instead.

Scope

  • Decide whether skills/release is ever executed from an installed plugin, or only from a clone of this repo. If only from a clone, the bare form is correct and this closes as documentation on the SKILL.md.
  • If it can run installed: prefix every script invocation in skills/release/SKILL.md with bash , in one change, and check the other skills' SKILL.md files for the same split.

References

  • rules/skill-authoring.md — Script References
  • #463 — the PR that surfaced it

🤖 Generated with Claude Code

https://claude.ai/code/session_01HK8Ca6dbz9zLgz4N5xgd6g

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read rules/skill-authoring.md under Script References and inspect skills/release/SKILL.md first. Determine whether skills/release runs from installed plugins, then search other skills' SKILL.md files for mixed script-invocation conventions. Done means the execution context is resolved and all applicable invocations consistently use the documented form.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash
Domain
documentation, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.