jbaruch / jbaruch/coding-policy

test(release): Tighten test_release_helpers.sh assertions and cover registry-baseline's jq guard

Open Beginner friendly
#459 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
2
Avg merge
9h 22m
Merged PRs (30d)
81

Description

Summary

Advisory findings from #455's final review round, deferred rather than folded — the PR was already mergeable and no blocking round was open (rules/review-severity.md Split Reading From Acting, rules/boy-scout.md Fold Into a Round Already in Flight).

Both in skills/release/tests/test_release_helpers.sh:

  1. Regex dots in literal assertions. grep -q "carries no .version" and grep -q "carries no .current" treat . as a wildcard, so the assertion still matches if the diagnostic stops naming the literal field. Use grep -qF.
  2. registry-baseline.sh's jq guard is uncovered. The suite exercises the absent-jq path for confirm-tessl-landed.sh only, though registry-baseline.sh has the same guard. Add the mirrored case using the same PATH-shadowing approach.

Neither changes shipped behavior — both make the suite stricter about behavior that is already correct.

Test plan

  • Both assertions use grep -qF and still pass
  • Mutating either diagnostic to drop the literal field name fails the suite
  • A jq-less PATH makes registry-baseline.sh exit 2 naming jq

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in skills/release/tests/test_release_helpers.sh and inspect the existing assertions and PATH-shadowing case for confirm-tessl-landed.sh. Use the issue's test plan as the completion checklist: literal-field assertions must remain strict, the registry-baseline.sh jq-less case must be covered, and the suite must pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
release, testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.