jayphelps / jayphelps/react-observable-subscribe
New subscription after prop changes uses old props
- Dominant language
- JavaScript
- Stars
- 134
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Haven't tested, but looking at the code,
https://github.com/jayphelps/react-observable-subscribe/blob/59085860d0369483ed2cf8c101aba77578a0bea4/src/index.js#L63-L68
When the props change, setupSubscription is called; however, setupSubscription uses this.props.children (the old props) instead of nextProps.children
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in src/index.js at lines 63-68 and trace setupSubscription during prop changes. Verify the subscription setup uses the new children from nextProps rather than the previous props, then confirm that a prop change creates a subscription for the updated children.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100