javivelasco / javivelasco/react-css-themr
Warning on console when using react v16.4
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 589
- Forks
- 65
- PR merge metrics
- No merged PRs in 30d
Description
When used with react v16.4, it throws an error in dev console which was introduced after v16.3 in support of removing the `componentWillMount`, `componentWillReceiveProps`, and `componentWillUpdate` lifecycle methods.
Since themr.js uses the `componentWillRecieveProps` lifecycle method, when used in a project with react v16.4, it throws a console warning. Moreover, this method will be deprecated in future releases of React ( v17.0 )
More about this [here](https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with themr.js and reproduce the React 16.4 development-console warning described in the issue. Review the componentWillRecieveProps and related lifecycle methods, then verify that the warning is gone and behavior remains correct with React 16.4.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 43/100