javivelasco / javivelasco/react-css-themr

Backport switch to `prop-types` package to the v1 branch to add compat with react 16

Open
#75 5 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
589
Forks
65
PR merge metrics
No merged PRs in 30d

Description

After updating to react 16, I encountered the following error:

```
TypeError: Cannot read property 'shape' of undefined
./node_modules/react-css-themr/lib/utils/themr-shape.js
node_modules/react-css-themr/lib/utils/themr-shape.js:7
```

Would be great to add a 1.8 release with the switch to the `prop-types` package to maintain compatibility for people like us stuck on toolbox v1 for now.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the v1 branch and the React 16 failure in node_modules/react-css-themr/lib/utils/themr-shape.js. Confirm that the prop-types package switch is applied and that the v1-compatible 1.8 release resolves the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.