javascript-tutorial / javascript-tutorial/en.javascript.info

Sync bot crushing partial reviews

Open
#3,744 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
25.5k
Forks
4k
PR merge metrics
No merged PRs in 30d

Description

Hi @iliakan

I discovered this in the Spanish repo,
but happens in the other repos too.
...

Previously, the bot used different branches for sync, closing the old PR and generating a new one over a new branch. Partial reviews were preserved in the closed PR.

Now, the bot closes the old PR but always uses the same branch, doing a force push on it that destroys any partial reviews.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the sync bot's branch and pull-request handling, then reproduce a sync with a partial review; done means synchronization no longer force-pushes over reviewed work and preserves the review context.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github
Domain
devops, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.