javan / javan/whenever

Test failures against v1.0.0

Open
#802 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
8.9k
Forks
715
PR merge metrics
No merged PRs in 30d

Description

Hi,

Thanks for maintaining this so far. However, while maintaining this in Debian, I noticed there are some test failures as follows:

  1) Failure:
Executable::bin/wheneverize::ARGV is not empty::file is a directory, but another param(s) are given as well#test_0001_prints STDERR [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:48]:
Expected /Too many arguments; please specify only the directory to wheneverize./ to match "".

  2) Failure:
Executable::bin/wheneverize::ARGV is empty::config directory exists, but file does not#test_0001_writes config file and prints STDOUT [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:107]:
Expected /\[add\] writing `.\/config\/schedule.rb'\n\[done\] wheneverized!/ to match "".

  3) Failure:
Executable::bin/wheneverize::ARGV is empty::config file already exists#test_0001_prints STDOUT and STDERR [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:74]:
Expected /\[done\] wheneverized!/ to match "".

  4) Failure:
Executable::bin/wheneverize::ARGV is not empty::file exists, but not a directory#test_0001_prints STDERR [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:30]:
Expected /`\/tmp\/this_is_a_file.txt' is not a directory./ to match "".

  5) Failure:
Executable::bin/wheneverize::ARGV is empty::config directory does not exist#test_0001_prints STDOUT and STDERR [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:89]:
Expected /\[add\] creating `.\/config'\n/ to match "".

  6) Failure:
Executable::bin/wheneverize::ARGV is not empty::file does not exist#test_0001_prints STDERR [/home/utkarsh/debian/ruby-team/whenever/ruby-whenever/test/unit/executable_test.rb:15]:
Expected /`\/tmp\/this_does_not_exist' does not exist./ to match "".

262 runs, 638 assertions, 6 failures, 0 errors, 0 skips
rake aborted!

Could we have a fix released for them?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/unit/executable_test.rb, especially the cases at lines 15, 30, 48, 74, 89, and 107, then run the test suite against v1.0.0 to reproduce the six failures. Trace why the expected STDERR and STDOUT are empty, and consider the work done when all listed executable tests pass with their expected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.