java-native-access / java-native-access/jna
Unnecessary synchronisation?
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.9k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
The entire body of both methods is part of the synch. block, so it seems unnecessary to synch the method as well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/com/sun/jna/internal/Cleaner.java at lines 61-62 and 79-80. Compare the method-level synchronization with the synchronized blocks covering each method body, then run the relevant JNA tests to confirm behavior is unchanged. Done means the redundant synchronization is removed without changing cleaner behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100