java-native-access / java-native-access/jna
Unnecessary synchronisation?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.9k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
The synch. here appears to be unnecessary:
https://github.com/java-native-access/jna/blob/365629530635440381f63939f7891456992fe91b/src/com/sun/jna/NativeLibrary.java#L186-L188
searchPaths is a ConcurrentHashMap, so does it need synch?
It also does not make sense to me to synch. on the value being added, rather than the target being updated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/com/sun/jna/NativeLibrary.java at lines 186-188 and inspect how searchPaths, the ConcurrentHashMap, and the synchronized block are used there. Determine whether the synchronization is needed and whether the update target is correct; the work is done when the synchronization behavior is justified and the relevant existing behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100