java-native-access / java-native-access/jna

NativeLibrary.getOptions allows options to be mutated

Open
#1,571 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
8.9k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

The getOptions() method returns a pointer to the options Map:

https://github.com/java-native-access/jna/blob/365629530635440381f63939f7891456992fe91b/src/com/sun/jna/NativeLibrary.java#L624-L626

This means the options can be mutated externally, which may cause unpredictable behaviour.
It also means that the class is not thread-safe, as changes to the options in one thread may not be seen by another.

One solution is to provide a copy of the options (note: this needs to be a deep copy)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/com/sun/jna/NativeLibrary.java at getOptions(), referenced in the issue, and inspect how the options Map is stored and returned. Determine the deep-copy behavior needed so callers cannot mutate library options, then verify that external changes no longer affect the library or create visibility problems between threads.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.