jatkinson1000 / jatkinson1000/archeryutils
Data from read_json functions could be stored as constants
- Dominant language
- Python
- Stars
- 20
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
I noticed during work on #67 that the read_json functions are called seperately in each AGB disciplines `make_classification_dict` function and stored to locals.
These could be called once and saved as constants, as any change to the data being loaded would require installing an updated version of archeryutils.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the read_json functions and each AGB discipline's make_classification_dict function. Review how the loaded data is currently assigned to locals, then identify the existing tests or validation for these functions. Done means the data is loaded once as constants and all classification functions continue to produce the same results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100