jasonslyvia / jasonslyvia/react-anything-sortable

`SortableItem.className` is discarded

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
457
Forks
82
PR merge metrics
No merged PRs in 30d

Description

`SortableItem.className` is discarded, is that accidental or in purpose?

As a result, code below does not work:

``` js

// this does not work either

```

Ref: https://github.com/jasonslyvia/react-anything-sortable/blob/4d7dbe6fee02a19a5a65980b58248d21d15b0fdf/src/SortableItemMixin.js#L99

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/SortableItemMixin.js around line 99, then trace how SortableItem and SortableContainer receive and render className. Reproduce both JSX examples from the issue and determine the intended className behavior. Done when the reported className values are preserved as expected and the relevant behavior is covered by the project's existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.