jasonrogena / jasonrogena/php-excel-reader

"Die" is a bad approach to error handling

Open
#80 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
PHP
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
The converter calls die() if it can't read a spreadsheet. Throw an exception
instead so calling programs can deal with the failure. Patch is attached.

```

Original issue reported on code.google.com by `d...@cimpress.com` on 6 Jul 2010 at 7:17

Attachments:
- [patch.txt](https://storage.googleapis.com/google-code-attachments/php-excel-reader/issue-80/comment-0/patch.txt)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the converter's spreadsheet-reading failure path and review the attached patch for the intended scope. Replace the direct die() failure with an exception that calling programs can handle, then verify that unreadable spreadsheets no longer terminate the caller unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.