jashkenas / jashkenas/underscore

Please let me know if you would like to review pull requests

Open
#3,014 10 comments 3 reactions 0 assignees View on GitHub
question starter
Dominant language
JavaScript
Stars
27.3k
Forks
5.4k
Avg merge
2d 5h
Merged PRs (30d)
1

Description

*I copied this text from https://github.com/jashkenas/backbone/issues/4268, so if you recognize it, that is not a coincidence.*

I have taken on the burden of maintaining Underscore. I also happen to believe that ideally, each code change should be reviewed by somebody other than the author.

When somebody else submits a pull request (please do!), I can obviously review it. When I submit a pull request myself (which I do a lot), it is not so obvious who might review it.

So far, I've been blindly `@mention`ing people who I thought (or hoped) might be interested in reviewing. I now feel that this pattern is not sustainable; I will miss people who are interested and annoy people who are not. Instead, I would like to actually know which people are interested in reviewing.

Of course, I'm hoping that expert contributors are interested, but non-expert reviewers are welcome, too. The more reviewers, the better.

- [ ] If you are interested in reviewing and you are already watching the repo so you will be aware of new pull requests, please leave a 👀.
- [ ] If you are interested in reviewing and you would like to be `@mention`ed to draw your attention, leave a 🚀.
- [ ] If you welcome *formal* review requests (so you see "review requested" in your GitHub notifications), leave a ❤️. If you opt-in for this, please also leave a comment to let me know what you consider an acceptable frequency and how quickly you expect to be able to respond (on average).
- [ ] If you just feel like voting, leave a 👍.

Text replies for other reasons also welcome, of course.

Contributor guide

Open the contributing guide

Research direction

This is a maintainer call for volunteer pull-request reviewers, not a code change. No files, tests, or implementation entry points are named; respond only if you want to opt into one of the listed review arrangements.

Written by the indexing model from the issue text.

Assessment

Tech stack
github
Domain
developer-experience
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.