jart / jart/json.cpp

Please consider including a pkg-config creation

Open
#17 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
794
Forks
38
PR merge metrics
No merged PRs in 30d

Description

I am upstreaming the library into nixpkgs via https://github.com/NixOS/nix/pull/14345/files

It would be great if the library emitted a pkg-config file itself so the authors can define it as they desire.

Other changes I recommend:
* allow double-conversion to be found via cmake (see my patch in the PR)
* allow for it to be a shared library (see my patch in the PR)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the build-related files changed in the referenced NixOS nix pull request 14345 and the library's current CMake configuration. Compare the requested pkg-config generation, double-conversion discovery, and shared-library support with that patch. Done means the library provides the requested packaging and build options without relying on downstream changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.