jariz / jariz/react-native-fingerprint-android
In case of error there should be return statement
- Dominant language
- JavaScript
- Stars
- 96
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
In my humble opinion in example:
in code fragment:
```
} catch(error) {
Toast.show(`Authentication aborted: ${error.message}`, Toast.SHORT);
}
```
there should be return statement:
```
} catch (error) {
console.log(error);
Toast.show(`Authentication aborted: ${error.message}`, Toast.SHORT);
return;
}
```
Bcs when i was getting ` [Error: Too many attempts. Try again later.]`
This code had executed: `Toast.show('Auth successful!', Toast.SHORT);`
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the example code containing the catch block and reproduce the reported “Too many attempts” error. Trace whether execution continues after the error handler; done means the error path no longer shows the success Toast while successful authentication still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, javascript, react-native
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100