don't break tabIndex
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 12k
- Forks
- 546
- PR merge metrics
- No merged PRs in 30d
Description
I use Pell as part of a form. Using 'TAB' to navigate the form fields, I'm first taken through all the buttons I have initialized for my Pell's instance before arriving in the editor with the cursor.
title_input (press 'TAB' here)
description_input (I expect the cursor to be in the editor and not looping through the icons)
Quick fix: add tabIndex=-1 to the icon's button elements
Currently I have this workaround after Pell is initialized:
document.querySelectorAll('.pell-button').forEach(button => button.setAttribute('tabIndex', "-1"))
but it would be cool to have this built-in.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where Pell creates the icon buttons with the .pell-button class. Verify the current tab order in a form, then make the buttons skipped by keyboard navigation as described in the issue. Done means tabbing moves from the title input directly to the editor instead of entering the toolbar icons.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100