jaredreich / jaredreich/pell

Safari: RangeError: Maximum call stack size exceeded.

Open
#165 7 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12k
Forks
546
PR merge metrics
No merged PRs in 30d

Description

I'm not sure if it's valid to use br as a defaultParagraphSeparator, but when using that it generates an error on Safari on this line:

`if (firstChild && firstChild.nodeType === 3) exec(formatBlock, '<' + defaultParagraphSeparator + '>');else if (content.innerHTML === '
')`

It seems to work okay in other browsers.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the Safari failure with `defaultParagraphSeparator` set to `br`, then inspect the reported `exec(formatBlock, '<' + defaultParagraphSeparator + '>')` branch and the adjacent `content.innerHTML === '
'` condition. Done means Safari no longer raises the maximum call stack error while paragraph editing continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.