jaredreich / jaredreich/pell

form OnSubmit trigger on click of any pell formatting button inside form.

Open
#149 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Hi @jaredreich,

I kept the pell editor inside a form which have an onSubmit event handler on it. While I click on any of the formatting button the form onSubmit got called.
The only workaround I got it to check the event inside the onSubmit method.

I wonder if this can be correctly handled in the pell.

I will raise a PR with the solution which I think of.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue by placing the pell editor inside a form and clicking each formatting button, then inspect how those buttons are created and handled. Done means formatting clicks no longer trigger the surrounding form's onSubmit handler while the editor actions still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.