jaredreich / jaredreich/pell

focus lost when click method returns false

Open
#111 3 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
JavaScript
Stars
12k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Plugin methods can return false especially when written in arrow format. The current onClick has a boolean AND expression to reset focus to the content element. This will fail when onClick returns false. Better to ditch the AND and use an arrow function with braces here.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the current onClick handler in the editor code and trace how its return value controls resetting focus to the content element. Verify the behavior when a plugin method returns false, and consider the issue complete when focus is still restored in that case without changing normal click behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.