jaredpalmer / jaredpalmer/the-platform

Passing additional attributes to Script

Open
#80 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
4.4k
Forks
106
PR merge metrics
No merged PRs in 30d

Description

the doc says that Scripts accepts "anything else you can pass to a <script> tag". But judging from the code
https://github.com/palmerhq/the-platform/blob/f721b0a2e44a86b4e5c0474c592ac46b3827ba9a/src/Script.tsx#L8-L14
it only passes src. However, some third-party libraries like paypal use data attributes to pass parameters to their scripts and that's not possible with Script

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Script.tsx at the referenced lines and compare its behavior with the Script documentation. Verify that attributes such as third-party data attributes can be passed through to the rendered script element, then confirm the documented behavior with an appropriate test or usage check.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.