jaredly / jaredly/reason-macros

Latest published version isn't working

Open
#3 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
106
Forks
0
PR merge metrics
No merged PRs in 30d

Description

thanks for updating reason-macros-bin, but I am having issues running latest published binaries. I could get it to run when I was manually copying the ppx for each platform etc.. but since you updated the library, bsb compilation is failing on my test project: you can see the pr here for a reproduction: https://github.com/sync/maccy/pull/4

First issue is that the ppx.js script needs to have execution permission set.

ninja: no work to do.
[2/7] Building src/Icon.mlast
sh: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js: Permission denied
File "/Users/anthonymittaz/Projects/Reason/maccy/src/Icon.re", line 1:
Error: Error while running external preprocessor
Command line: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppx064345' '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppx8e5f1f'

[3/7] Building src/Index.mlast
sh: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js: Permission denied
File "/Users/anthonymittaz/Projects/Reason/maccy/src/Index.re", line 1:
Error: Error while running external preprocessor
Command line: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppx6fb90a' '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppx9625ae'

and if you check master it is working fine
sorry to be a pain 😃
btw once i change the permisison issue i get another error

File "/Users/anthonymittaz/Projects/Reason/maccy/src/Icon.re", line 1:
Error: External preprocessor does not produce a valid file
Command line: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppxc42632' '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppx8228fc'

[3/7] Building src/Index.mlast
File "/Users/anthonymittaz/Projects/Reason/maccy/src/Index.re", line 1:
Error: External preprocessor does not produce a valid file
Command line: /Users/anthonymittaz/Projects/Reason/maccy/node_modules/reason-macros-bin/ppx.js '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppxa6a3c9' '/var/folders/zr/9zn3j55909q8lnvg5r967qs80000gn/T/camlppxa4eb2f'

error Command failed with exit code 2.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the published-binary failure with the reproduction PR linked in the issue, focusing on node_modules/reason-macros-bin/ppx.js and the builds of src/Icon.re and src/Index.re. Check both the permission-denied error and the later invalid-preprocessor-output error; done means the latest published binaries compile the reproduction successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system, compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.