jaredly / jaredly/reason-language-server

Does not work for bs-platform 7.3.1 yet

Open
#447 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
OCaml
Stars
649
Forks
85
PR merge metrics
No merged PRs in 30d

Description

bs-platform: 7.3.1
reason-vscode: 1.7.8
OS: MacOS 10.15.4

If a file contains no errors, compilation works just fine. If there are some error, plugin does not highlight them, file silently does not compile.

I can attach full /node_modules/.lsp/debug.log if needed.

I can see some signs of found error in the debug.log.
```
FAILED: components/TopPanel.cmj components/TopPanel.cmi /Users/user/work/myproject/components/TopPanel.bs.js
/Users/user/work/myproject/node_modules/bs-platform/darwin/bsc.exe -bs-package-name with-reasonml -bs-package-output commonjs:components -color always -bs-suffix -I common -I layouts -I components/svg -I components -I bindings -I /Users/user/work/myproject/node_modules/reason-react/lib/ocaml -I /Users/user/work/myproject/node_modules/bs-css/lib/ocaml -I /Users/user/work/myproject/node_modules/bs-css-emotion/lib/ocaml -bs-super-errors -o components/TopPanel.cmj components/TopPanel.reast

We've found a bug for you!
/Users/user/work/myproject/components/TopPanel.re 14:18-20

12 ┆ style([
13 ┆ width(64->px),
14 ┆ height(48->pxg),
15 ┆ background(hex(expanded ? "24CFED" : "25375C")),
16 ┆ ...CssTools.centerWithFlex,

The value pxg can't be found

Hint: Did you mean px?

FAILED: subcommand failed.
```

On latest official version bs-platform@7.2.2 works as expected. I'll stick with it for now.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the failure with bs-platform 7.3.1 and reason-vscode 1.7.8 on the reported MacOS setup, using the components/TopPanel.re example and /node_modules/.lsp/debug.log. Compare the behavior with bs-platform 7.2.2; done means compilation errors are highlighted instead of the file failing silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.