jaredly / jaredly/reason-language-server
Unexpected output from per_value_codelens
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 649
- Forks
- 85
- PR merge metrics
- No merged PRs in 30d
Description
Working through the Reason book by Amin and Ayeva, here is a screenshot showing the output from the codelens, note the book says the 3rd value should be `'a => {. x: 'a}`.
After every edit (I guess every parse of the AST?) causes some of the dynamic types to be iterated (2nd and 3rd values in these screenshots) resulting in a bit of mental overhead to read the codelens.
[debug.log](https://github.com/jaredly/reason-language-server/files/2846681/debug.log)
Also running action "Restart Reason Language Server" does cause the dynamic types to reset to the 1st state.
PS:
thanks for reason-vscode, this is one of the best vscode extensions I have encountered yet!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Reason book example in VS Code and review the per_value_codelens output alongside the linked debug.log. Compare the values after edits and after using "Restart Reason Language Server"; done means the codelens remains stable and matches the documented third value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100