jaredly / jaredly/reason-language-server
Problems with the interface file
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 649
- Forks
- 85
- PR merge metrics
- No merged PRs in 30d
Description
I discovered two problems related to the "Add to interface file" feature.
1. If the identifier name is an operator, the generated code in the interface file will be malformed (missing parentheses), causing a syntax error. For instance:
let (/==) = (a: int, b: int): int => a + b;
results in
let /==: (int, int) => int;
2. "Add to interface file" doesn't appear for explicit modules. That is, it's not possible to generate a corresponding module type in the interface file with the feature.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of the "Add to interface file" feature and reproduce the operator example to inspect the malformed generated code. Then investigate the explicit-module path; done means operator identifiers generate valid interface syntax and explicit modules offer corresponding module types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100