jaredly / jaredly/reason-language-server

Errors shown one at a time only in a source file and types not shown on hover if there is an error in the same file

Open
#198 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
OCaml
Stars
649
Forks
85
PR merge metrics
No merged PRs in 30d

Description

1) reason-vscode plugin shows only one error at a time and
2) does not show type when there is an error elsewhere in the same file.
I thought these might be related problems and filed in one issue.

For example:

Example 1. There are errors with both variables `first_error` and `second_error`, but it's showing the error for the first one only.
![image](https://user-images.githubusercontent.com/16353531/48922500-e1904b00-eec8-11e8-8c11-12710dc580b9.png)

Example 2. There is a type error with `first_error` and a syntax error with `second_error`, but the plugin is showing on the syntax error and the type error will slip away until the syntax error is fixed.
![image](https://user-images.githubusercontent.com/16353531/48922574-64b1a100-eec9-11e8-80ed-db5d49831f7d.png)

Example 3. (no type when there is an error) In the screenshot below my cursor was on the `some_int`, but it's type was not shown, as there is an error below (screenshot removes my cursor though, but it is on `some_int` with no type shown.)
![image](https://user-images.githubusercontent.com/16353531/48922610-c5d97480-eec9-11e8-8307-4cb094a9cecf.png)

Both of these problems are somehow absent in `Ocaml and Reason IDE` by Darrin Morrison, if that's of any help.
![image](https://user-images.githubusercontent.com/16353531/48922668-34b6cd80-eeca-11e8-9e36-eb5117cd7aad.png)
![image](https://user-images.githubusercontent.com/16353531/48922703-5d3ec780-eeca-11e8-91e8-d83feeb77d66.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the three reported cases in the reason-vscode plugin and compare them with the behavior shown for Ocaml and Reason IDE. Trace how multiple diagnostics and hover type information are produced; done means both errors remain visible and the type still appears when another error exists in the file.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml, vscode
Domain
devtools, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.