jaredly / jaredly/reason-language-server

AsYouType compilation doesn't factor in interface files

Open
#168 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
OCaml
Stars
649
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Open the `reason-react` project, and get a "variables not generalized" error on `ReasonReact.re`.

This error is legit if one deletes `ReasonReact.rei`, in which case the compiler gives the error from the command-line.

I've double checked with the other vscode extension that the error is not reported. (And that it is, if we delete `ReasonReact.rei`).

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the error in the `reason-react` project using `ReasonReact.re` with and without `ReasonReact.rei`, and compare the command-line compiler with the other VS Code extension. Then trace the language server's AsYouType compilation path to determine how interface files are handled; done means the erroneous "variables not generalized" report is absent when the interface file exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.