jaredhanson / jaredhanson/passport
HTTP Strategy abandoned and broken
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 23.5k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Description
The basic strategy project is abandoned and flawed. A simple example : you can have a colon ":" in the password.
The github "https://github.com/jaredhanson/passport-http" has even 28 pull requests, including for this issue and still it's ignored.
I recommend to archive the project and advertise "github.com/AaronDewes/modern-passport-http" in your documentation, which is not abandoned and addresses the issues AND it's 100% compatible
### Expected behavior
The most basic authentication is flawed. A colon is a valid character for a password and should simple not break this awesome project. The user should get authenticated
### Actual behavior
You get a wrong password error
### Steps to reproduce
Implement basic authentication and use colon in your password
### Environment
* Operating System:
* Node version: 16.14.0
* passport version: 0.6.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository files or tests are named. Start by reviewing the linked passport-http project and reproducing basic authentication with a colon in the password; completion would require resolving that behavior or documenting the proposed replacement and archival decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100