jaredhanson / jaredhanson/passport-http

Passwords containing ':' are not read properly

Open
#41 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
261
Forks
112
PR merge metrics
No merged PRs in 30d

Description

Since userid and password are read as index 0 and 1 of credentials.split(':') the remaining part of the password after ':' is discarded.

Contributor guide

Open the contributing guide

Research direction

Locate the authentication parsing code that uses credentials.split(':') and inspect how the username and password are extracted. Confirm the expected behavior for passwords containing colons, then add coverage showing that the complete password is preserved and run the relevant project tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
authentication, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.