jaredhanson / jaredhanson/passport-github

Use the Authorization HTTP header instead of `access_token` query parameter

Open
#75 18 comments 18 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
535
Forks
290
PR merge metrics
No merged PRs in 30d

Description

Today I got an email containing the following.

> Hi @timqian,
>
> On February 3rd, 2020 at 22:22 (UTC) your application (repo-analytics) used an access token (with the User-Agent passport-github) as part of a query parameter to access an endpoint through the GitHub API:
>
> https://api.github.com/user/emails
>
> Please use the Authorization HTTP header instead as using the `access_token` query parameter is deprecated.
>
> Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
> Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.
>
> Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.
>
> Thanks,
> The GitHub Team

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the GitHub API request for /user/emails and trace how its authentication is supplied. Verify the request uses the Authorization HTTP header rather than the access_token query parameter, then exercise the relevant authentication or API test if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript, node.js
Domain
api, authentication
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.