jaredhanson / jaredhanson/passport-github

deserialize is never called..

Open
#45 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
535
Forks
290
PR merge metrics
No merged PRs in 30d

Description

Visiting /p/foo
Returns

```
[2015-06-22 22:15:02.736] [INFO] console - Trying to access a pad /p/foo
[2015-06-22 22:15:02.736] [WARN] console - isAuthenticated false
[2015-06-22 22:15:02.736] [WARN] console - passing back to auth as not authenticated
[2015-06-22 22:15:04.122] [INFO] console - successful auth through Github
[2015-06-22 22:15:04.123] [INFO] console - serialized user { provider: 'github', ... omitted ... }
[2015-06-22 22:15:04.128] [INFO] console - Redirecting back to home after succesful auth
```

Then trying to visit another pad without stopping / starting Etherpad or closing browser returns..

```
[2015-06-22 22:16:10.500] [INFO] console - Trying to access a pad /p/oWtSRH2g01
[2015-06-22 22:16:10.500] [WARN] console - isAuthenticated false
[2015-06-22 22:16:10.500] [WARN] console - passing back to auth as not authenticated
[2015-06-22 22:16:11.827] [INFO] console - successful auth through Github
[2015-06-22 22:16:11.827] [INFO] console - serialized user { provider: 'github',
```

So the isAuthenticated persistence isn't being kept

https://github.com/JohnMcLear/ep_oauth/blob/master/auth.js#L28 -- Am I okay to not use `app.use(express.methodOverride());` and the other express calls in the example app?

These methods don't seem to be responsible for persistence.. I'm ultimately going to write to/read from the database layer but for now I want a clean sample/example to do proof of concept.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with auth.js around line 28 and the example app's Express middleware setup. Reproduce the login flow from /p/foo, then visit another pad without restarting Etherpad or closing the browser, and trace why isAuthenticated is false; done means authentication persists across the second visit.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
authentication, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.