jaredhanson / jaredhanson/oauth2orize

When using auth_code grant, code redirects with query params, token with hash

Open
#131 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.5k
Forks
472
PR merge metrics
No merged PRs in 30d

Description

When you request an auth_code grant, there is a difference in the redirect between code and token.

Code:
https://github.com/jaredhanson/oauth2orize/blob/master/lib/grant/code.js#L138

Token:
https://github.com/jaredhanson/oauth2orize/blob/master/lib/grant/token.js#L145

What is the reasoning for this difference?

Contributor guide

Open the contributing guide

Research direction

Compare the redirect construction in lib/grant/code.js at line 138 with lib/grant/token.js at line 145. Start by tracing how each grant builds its redirect response and consult the surrounding OAuth flow; the issue is complete when the difference is explained and any intended change is identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authentication, backend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.